Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Implement responsive mobile menu + remove old select-based mobile menu #63

Closed
wants to merge 1 commit into from
Closed

Implement responsive mobile menu + remove old select-based mobile menu #63

wants to merge 1 commit into from

Conversation

jussikinnula
Copy link
Contributor

Fixes #62

I'm open for any additional changes, we use this implementation on current customer project I'm working on. Works very well on latest iPhone and Android.

@mpetrovich
Copy link
Owner

Great idea!

We're in the midst of completely rewriting the markup and will definitely incorporate this approach. One concern is the JS-based sizing of the navigation pane: it's a little brittle and could perhaps be achieved in CSS.

@jussikinnula
Copy link
Contributor Author

The reason of the JS-based sizing is that I didn’t want go change the normal version in same commit. So this change only adds responsiveness and removes the old select-based menu.

With some refactoring of the whole menu and use of flexbox it could be possible to remove the JS bits.

@jussikinnula
Copy link
Contributor Author

Also, we have been using the JS-based approach and tested with variety of devices. The JS-parts only run on mobile, and it’s pretty standard way to do fixed scrollable menus (allthough it’s ”legacy way”, due to nowadays flexbox and vw/vh units being available).

@mpetrovich mpetrovich closed this Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile menu should be responsive
2 participants